Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment: general use cases #2

Closed
KrzysztofMadejski opened this issue Feb 19, 2018 · 7 comments
Closed

Misalignment: general use cases #2

KrzysztofMadejski opened this issue Feb 19, 2018 · 7 comments
Assignees

Comments

@KrzysztofMadejski
Copy link
Member

It would be nice if the text and icons were aligned horizontally.

misalign1

@simonfossom
Copy link

Adjusted it in design!

@IronRunes
Copy link
Contributor

@simonfossom
Copy link

It's not by design. We talked that you'll put this in the html table...
image

@IronRunes
Copy link
Contributor

I thought we were putting the pros and cons in an html table (done that, btw). I aligned icons & related text horizontally, as per Krzystof's request.
No biggie though, can do

IronRunes added a commit that referenced this issue Feb 28, 2018
@KrzysztofMadejski
Copy link
Member Author

On my chrome (Version 64.0.3282.186, Ubuntu 17.04) the text is aligned, but icons still are not aligned horizontally (see below).

Let me know @IronRunes if I should test some css live.

screenshot from 2018-02-28 09-01-45

@IronRunes
Copy link
Contributor

so you want everything aligned horizontally, and not reciprocally (i.e. icon aligned to text, as is now).
ok, will do.

@IronRunes
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants