Add support for module parameters #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back in the day, it was called GENERICS in cocotb cocotb/cocotb#692 I have no strong opinion on naming. |
|
Would be great to add some simple test for this. I can also add later. |
|
Hmm, interesting that it was removed from cocotb. Seems like at least supporting them at the top-level in a standard way would be a reasonable compromise, anything more advanced can then be done manually. |
8 tasks
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for passing module parameters to the simulator. This PR only adds support for icarus verilog and verilator. For both of these simulators, the parameters are handled during compilation, so setting force_compile is recommended.