Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: build life cycle callbacks (prehtml, prepdf, etc) #13

Open
bmcminn opened this issue Nov 11, 2020 · 2 comments
Open

Feature: build life cycle callbacks (prehtml, prepdf, etc) #13

bmcminn opened this issue Nov 11, 2020 · 2 comments

Comments

@bmcminn
Copy link

bmcminn commented Nov 11, 2020

I tend to use C style inline comments (// comment here) in my markdown files because:

  • my editor theme grays out <!-- html --> comments making them hard to read/see
  • I like being able to use // TODO: ... and // NOTE: ... as specific notes to myself for future review

It would be helpful if I could register a standard event hook callback in my ibis.php that BuildCommand.php issues before converting a file to HTML from markdown.

I have a working proof of concept in my own fork of the repo that introduces a prehtml() global function that one can optionally provide in their ibis.php if they want to preprocess their markdown content for whatever reason.

@themsaid
Copy link
Owner

That's a nice idea. Can you open a Pull Request?

@bmcminn
Copy link
Author

bmcminn commented Nov 11, 2020

Working on a PR right now

bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 11, 2020
Adds user editable functions to ibis.php that allows users to modify
content via global event hook callbacks.

Fixes issue themsaid#13
@bmcminn bmcminn changed the title Feature: conversion life cycle callbacks (pre/post markdown, pre/post html, etc) Feature: conversion life cycle callbacks (prehtml, prepdf, etc) Nov 11, 2020
@bmcminn bmcminn changed the title Feature: conversion life cycle callbacks (prehtml, prepdf, etc) Feature: build life cycle callbacks (prehtml, prepdf, etc) Nov 11, 2020
bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 15, 2020
Adds optional user defined functions to ibis.php that allows users to modify content at different points in the rendering process

Fixes themsaid#13
bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 15, 2020
Adds optional user defined functions to ibis.php that allows users to modify content at different points in the rendering process

Fixes themsaid#13

update readme'
bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 15, 2020
Adds optional user defined functions to ibis.php that allows users to modify content at different points in the rendering process

Fixes themsaid#13

update readme'

''
bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 15, 2020
Adds optional user defined functions to ibis.php that allows users to modify content at different points in the rendering process

Fixes themsaid#13

update readme'

''

''
bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 15, 2020
Adds optional user defined functions to ibis.php that allows users to modify content

Fixes themsaid#13
bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 15, 2020
Adds optional user defined functions to ibis.php that allows users to modify content

Fixes themsaid#13
bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 15, 2020
Adds optional user defined functions to ibis.php that allows users to modify content

Fixes themsaid#13
bmcminn added a commit to bmcminn/ibis that referenced this issue Nov 15, 2020
Adds optional user defined functions to ibis.php that allows users to modify content

Fixes themsaid#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants