-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync is ignoring anything outside views #21
Comments
@themsaid i think you should close this issue now :D. |
@ahmedash95 Question : I have translations for enums. Here is some code : Enum declaration in
|
@vpratfr config/enums.php out of sync scope becase it just an array doesn't use any lang methods! . or I misunderstand ? |
The above method call will be ignored by the sync command as it contains a dynamic key, only specific key calls are considered. If you have an idea on how to support this type of calls I'll be glad to consider it. |
There is no real way to support it. However, good to know it is ignored, I think that is the best way to handle it. How about the existing translation messages in It would be handy (and maybe safe) to be able to specify a list of files to ignore in the lang folders when sync-ing. |
Actually I think we are mixing two different things:
Both of them are doing something different. And I don't really know what your package does. Maybe it would be a good idea to have a command for each? |
Nope, it won't get erased, it'll stay untouched. Regarding ignoring files, why would you want to ignore a file? I don't mind having an option Regarding your other opened issue, is it still not working? Did you succeed figuring out what was wrong? |
Ignoring a file is in case a translation is not in code anymore and you remove them from language files. If you don't do any removal of unused translation keys, then ignoring is not really necessary. |
I'm not sure I quite understand the use case, do you mean if you remove the |
v1.2.2 now looks inside the app directory in addition to the views directory. |
There are lots of places where we have messages: controllers, validation, events, etc. All of them are not taken into account, just the views.
This would be fair to incorporate those classes into the sync process.
The text was updated successfully, but these errors were encountered: