Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling on the map doesn't stop scrolling on the page #50

Closed
kajgiesbersflavour opened this issue Sep 22, 2021 · 2 comments
Closed

Scrolling on the map doesn't stop scrolling on the page #50

kajgiesbersflavour opened this issue Sep 22, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@kajgiesbersflavour
Copy link
Contributor

Since updating jsvectormap to 1.3, when scrolling on the map, the page scrolls too. This causes weird behaviour.

I have fixed this on our branch with this change: kajgiesbersflavour@66e91a6

I made a sample to show the issue here: kajgiesbersflavour@ea678a2

Try zooming in and out on that sample page without the fix and you will see what I mean.

I am not sure removing the passive: true can cause any issues, but I haven't found any and it seems to fix the problem for us.
@themustafaomar themustafaomar added the bug Something isn't working label Sep 23, 2021
@themustafaomar
Copy link
Owner

Well, apparently this is a bug.

This fix will be applied on the next version, you're welcome to send a PR.

The passive option will be removed as well.

Thank you!

@kajgiesbersflavour
Copy link
Contributor Author

Thanks! I will make a pull request

@kajgiesbersflavour kajgiesbersflavour mentioned this issue Sep 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@themustafaomar @kajgiesbersflavour