added clear() #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +17,13 @@ var timeout = require('timeout-then'); | |||
| timeout(100).then(function () { | |||
| console.log('blah'); | |||
| }); | |||
|
|
|||
| // clear timeout | |||
| var promise = timeout(100); | |||
There was a problem hiding this comment.
Is var timer = timeout(100) more semantic?
|
updated changes |
| @@ -2,7 +2,12 @@ | |||
| var Promise = require('native-or-bluebird') | |||
|
|
|||
| module.exports = function (interval) { | |||
| return new Promise(function (resolve) { | |||
| setTimeout(resolve, interval || 0) | |||
| var timeoutId | |||
There was a problem hiding this comment.
prefer timer, in node, setTimeout return a obj!
There was a problem hiding this comment.
Okay, I was just following MDN
https://developer.mozilla.org/en-US/docs/Web/API/WindowTimers/setTimeout
Will change
Typed using my thumbs..
On Jun 9, 2016, at 6:55 AM, haoxin notifications@github.com wrote:
In index.js:
@@ -2,7 +2,12 @@
var Promise = require('native-or-bluebird')module.exports = function (interval) {
- return new Promise(function (resolve) {
- setTimeout(resolve, interval || 0)
- var timeoutId
prefer timer, in node, setTimeout return a obj!—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Closed
|
@jonathanong need npm right to publish a new version! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7 , let me know if you have another api in mind
Thanks!