fix: set a valid parserOptions.ecmaVersion
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [roboter](https://github.com/thenativeweb/roboter) from 12.0.0 to 12.1.2. - [Release notes](https://github.com/thenativeweb/roboter/releases) - [Changelog](https://github.com/thenativeweb/roboter/blob/main/CHANGELOG.md) - [Commits](thenativeweb/roboter@12.0.0...12.1.2) --- updated-dependencies: - dependency-name: roboter dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/roboter-12.1.2
goloroden
approved these changes
Aug 26, 2021
goloroden
pushed a commit
that referenced
this pull request
Aug 26, 2021
## [3.30.14](3.30.13...3.30.14) (2021-08-26) ### Bug Fixes * set a valid `parserOptions.ecmaVersion` ([#403](#403)) ([0024415](0024415))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been having some problems with false positives lately. Namely, the
prefer-constandno-implicit-globalsrules seemed to disregard scope. With the help of some very helpful folks over at eslint, we've found the culprit.This line in our config is not supported by
@typescript-eslint/parserand it will fall back to at least ES9. What version it falls back to is not entirely clear to me, but it seems to be a version without block scoping, where all variables are hoisted. This causes scope-aware rules to misreport.This PR changes the
parserOptions.ecmaVersionfrom"latest"to12, which is the latest ratified version. This means we will have to bump this version every year. Since our configuration is executable, maybe we can find a way to query the latest version automatically.Since this error in our configuration breaks some of our builds, we should probably merge this fix first and then figure out how to maintain the pinned version later.