Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove node-sass from deps #1439

Merged
merged 2 commits into from
Mar 2, 2021
Merged

remove node-sass from deps #1439

merged 2 commits into from
Mar 2, 2021

Conversation

angle943
Copy link
Contributor

@angle943 angle943 commented Mar 1, 2021

Remove Node-sass from our dependency because it's a pain in the ass

Copy link
Contributor

@thesanjeevsharma thesanjeevsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angle943 I am curious to know what problems were you facing with node-sass?

@angle943
Copy link
Contributor Author

angle943 commented Mar 1, 2021

@thesanjeevsharma I and others had issues npm install when either using the wrong node version or something else.

node-sass is also deprecated, so might as well migrate to sass (ref: https://www.npmjs.com/package/node-sass)

@angle943 angle943 merged commit 26fd151 into development Mar 2, 2021
@angle943 angle943 deleted the remove-node-sass branch March 2, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants