Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed everything to work with the newer version of ChibiOS #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Rayvert64
Copy link

I figured I would fix this for you(and everyone else) so that it would work with the newest version of ChibiOS.
Right now the only thing that I find iffy is the Cargo.toml file. (Yeah the "*"s...)

If you want I could just fix it right away, in next pull request I will have probably fixed it.(I am also working on the readme)

Oh also, this is my first pull request ever, so... #hashtagfirst? :P

@thenewwazoo
Copy link
Owner

Fan-damn-tastic! Thank you! My work in the embedded space came to a very sudden halt and has languished, so thank you so much for the PR (and congratulations on your first!). You're right - the * in Cargo.toml is a bit... icky. And makes me fear for future compatibility if there are breaking changes that I (or some other helpful person such as yourself) don't track. It looks like cc is 1.0 now, so even just a major version where possible would help.

@Rayvert64
Copy link
Author

Yeah so for some reason, I am getting compile errors still after I clone the repo to a different location in my computer, one failure was due to me forgeting to update the ChibiOS submodule, easy fix, the other seems to be an error with apps.rs. For some reason I can still compile it where I first worked on it.
derp

@thenewwazoo
Copy link
Owner

That looks to me like the definition of osPriorityNormal might have changed in the ChibiOS source code, and is not longer in the bindgen output

@Rayvert64
Copy link
Author

Rayvert64 commented Aug 25, 2019

So it turns out that *s really mess things up. I assumed that cargo would just grab the newest version of whatever dependency you need, if course that is not what happens; I guess cargo will just chose a random one? Anywho I'll push the changes to rayvert64-Dev.(and create a new testing branch so that I can make sure that my pull requests are clean)

In the end a newer version of bindgen was the issue

@thenewwazoo
Copy link
Owner

Sorry I didn't have a chance to test this over the weekend. Since I probably won't have a chance to do so this week, if you can confirm it builds and runs from a fresh checkout, I'll go ahead and merge. :)

@Rayvert64
Copy link
Author

I know that it compiles, but I don't have access to my hardware right now so it might take me a bit. In the meantime I am getting OVPsim installed on the computers I work with so that I can test it on emulated hardware.

Also can you tell me exactly on what hardware you tested it on, I was thinking of buying a development board to match what you tested on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants