fix: gbc screen resolution #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 27, 2023 22:21
- initial pass at fixing gbc screen resoution shifts - emulator controls canvas, let it dictate the canvas resolution and height - bump wasm files
- tentative attempt at containing different screen resolutions in the screenwrapper - avoids layout jerk - todo: refactor to scale canvas on resize
- use object fit contain to keep the canvas aspect ratio contained regardless of the parent aspect ratio - remove unnecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
allows breaking aspect ratio of the canvas wrapper
canvas aspect ratio is now handled in css
video dimensions are now handled by the wasm emulator
bumps wasm files
End result:
Checks: