Debug DirectedSphereExclusion #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 40.64% 40.35% -0.30%
==========================================
Files 8 8
Lines 556 560 +4
==========================================
Hits 226 226
- Misses 330 334 +4
|
|
I added the same fix to the |
|
Can you add one test for this case? Thank you. @marco-2023 |
|
Hello @FanwangM, I did those minor fixes because otherwise, the Jupyter Notebook did not run. I think Ali is working on fixing the OptiSim module so I tried not to change too many things (to avoid getting in his way). Should I still implement a test for this? |
|
Hi @marco-2023. Yes, once you have a small test for the directed sphere exclusion, I will merge this PR. Thank you. |
The select_from_cluster method did not use the data from the cluster labels. Because of this, the algorithm used the whole data instead of the samples of the cluster from which the selection should occur. The algorithm then failed if cluster labels were used.
The select_from_cluster method did not use the data from the cluster labels. Because of this, the algorithm used the whole data instead of the samples of the cluster from which the selection should occur.
FanwangM
force-pushed
the
debug_DirectedSphereExclusion
branch
from
8771a76
to
eefe251
Compare
FanwangM
approved these changes
Aug 23, 2023
JackyZzZz
pushed a commit
to JackyZzZz/Selector
that referenced
this pull request
Jun 14, 2024
…lusion Fix the problem where `select_from_cluster` method did not use the data from the cluster labels
FanwangM
added a commit
that referenced
this pull request
Jul 2, 2024
Fix the problem where `select_from_cluster` method did not use the data from the cluster labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The select_from_cluster method did not use the data from the cluster labels. Because of this, the algorithm used the whole data instead of the samples of the cluster from which the selection should occur. The algorithm then failed if cluster labels were used.
This PR fixes #154