Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove final python2 pieces #38

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Remove final python2 pieces #38

merged 1 commit into from
Apr 9, 2019

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Apr 9, 2019

Fixes #8

@tovrstra tovrstra merged commit 90017bb into theochem:master Apr 9, 2019
@tovrstra tovrstra deleted the py3 branch April 9, 2019 18:55
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #38 into master will decrease coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #38     +/-   ##
=========================================
- Coverage   98.05%   97.56%   -0.5%     
=========================================
  Files          18       18             
  Lines        3035     2870    -165     
  Branches     1796      262   -1534     
=========================================
- Hits         2976     2800    -176     
  Misses         31       31             
- Partials       28       39     +11
Impacted Files Coverage Δ
python-cellcutoff/cellcutoff/ext.pyx 75.42% <ø> (ø) ⬆️
python-cellcutoff/cellcutoff/__init__.py 100% <100%> (ø) ⬆️
cellcutoff/decomposition.h 86.95% <0%> (-13.05%) ⬇️
cellcutoff/sphere_slice.cpp 95.77% <0%> (-2.9%) ⬇️
cellcutoff/tests/test_usage.cpp 98.5% <0%> (-1.5%) ⬇️
cellcutoff/iterators.cpp 92.38% <0%> (-0.42%) ⬇️
cellcutoff/tests/test_cell.cpp 99.62% <0%> (-0.15%) ⬇️
cellcutoff/cell.cpp 95.8% <0%> (-0.15%) ⬇️
cellcutoff/tests/test_sphere_slice.cpp 98.78% <0%> (-0.08%) ⬇️
cellcutoff/tests/test_iterators.cpp 100% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d08f96...8714fa8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant