Use attrs for IOData class #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes theochem#73 Not all pylint exclusions can be removed, essentially due to pylint bugs resulting in many false negatives, see https://stackoverflow.com/questions/47972143/using-attr-with-pylint pylint-dev/pylint#1694 The good solution is to disable all type-checking warnings of pylint and to use a proper type checker like mypy instead. Related changes: - reaction_coordinate, ipoint, npoint, istep and nstep move to extra. - many getattr and hasattr calls are replaced by nicer code. - ArrayTypeCheckDescriptor is replaced by two simple functions. - Document IOData.charge - Bug got fixed in poscar format (gvecs)
This was referenced May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
Not all pylint exclusions can be removed, essentially due to pylint bugs resulting in many false negatives, see
https://stackoverflow.com/questions/47972143/using-attr-with-pylint
pylint-dev/pylint#1694
The good solution is to disable all type-checking warnings of pylint and to use a proper type checker like mypy instead.
Related changes: