Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppVeyor continuous integration #8

Merged
merged 2 commits into from Aug 24, 2017
Merged

Conversation

FarnazH
Copy link
Member

@FarnazH FarnazH commented Aug 23, 2017

There is a problem with iodata/molden.py on Windows due to file.seek() and file.tell() methods. This is because a different newline character is used on Windows, so seek does not take you back to the exact same place (beginning of the previously read line).

@FarnazH
Copy link
Member Author

FarnazH commented Aug 23, 2017

P.S. This is a problem with only Python 2.7 on Windows apparently because Python 3.5 and 3.6 changed the way file.seek() and file.tell() work.

@tovrstra
Copy link
Member

We should probably rewrite the code not to use seek and tell. That is a rather fragile technique anyway.

@tovrstra
Copy link
Member

P.S. I've updated the webhook to point to Roberto's account on AppVeyor.

@tovrstra
Copy link
Member

This is the badge for appveyor:

[![Build status](https://ci.appveyor.com/api/projects/status/s1v03mj127dmoi7s/branch/master?svg=true)](https://ci.appveyor.com/project/theochem-ci-bot/iodata/branch/master)

When you push this a new commit (e.g. with the badge) it should start testing on appveyor as well.

@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          28       28           
  Lines        3087     3087           
  Branches      422      422           
=======================================
  Hits         2920     2920           
  Misses         82       82           
  Partials       85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98d30a...fbc8361. Read the comment docs.

@tovrstra
Copy link
Member

We'll fix the seek and tell later. Merging.

@tovrstra tovrstra merged commit dd36b16 into theochem:master Aug 24, 2017
@FarnazH FarnazH deleted the appveyor branch April 20, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants