fix(HLS): Report HLS playlist updates as media playlist in network fi…

…lters (shaka-project#5120)
theodab · Mar 29, 2023 · c2a59d0 · c2a59d0
1 parent 3f35f5d
commit c2a59d0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/hls/hls_parser.js b/lib/hls/hls_parser.js
@@ -345,7 +345,8 @@ shaka.hls.HlsParser = class {
       // 'EXT-X-SKIP' tag in the media playlist.
       uriObj.setQueryData(new goog.Uri.QueryData('_HLS_skip=YES'));
     }
-    const response = await this.requestManifest_(uriObj.toString());
+    const response =
+        await this.requestManifest_(uriObj.toString(), /* isPlaylist= */ true);
     if (!streamInfo.stream.segmentIndex) {
       // The stream was closed since the update was first requested.
       return;

diff --git a/test/hls/hls_live_unit.js b/test/hls/hls_live_unit.js
@@ -372,7 +372,7 @@ describe('HlsParser live', () => {
 
         // We saw one request for the video playlist, which signalled "ENDLIST".
         const type =
-            shaka.net.NetworkingEngine.AdvancedRequestType.MASTER_PLAYLIST;
+            shaka.net.NetworkingEngine.AdvancedRequestType.MEDIA_PLAYLIST;
 
         fakeNetEngine.expectRequest(
             'test:/video',
@@ -844,7 +844,7 @@ describe('HlsParser live', () => {
         // No segment requests were needed to get the start time.
         expect(fakeNetEngine.request).toHaveBeenCalledTimes(1);
         const type =
-            shaka.net.NetworkingEngine.AdvancedRequestType.MASTER_PLAYLIST;
+            shaka.net.NetworkingEngine.AdvancedRequestType.MEDIA_PLAYLIST;
         fakeNetEngine.expectRequest(
             'test:/video',
             shaka.net.NetworkingEngine.RequestType.MANIFEST,
@@ -892,7 +892,7 @@ describe('HlsParser live', () => {
             'test:/video?_HLS_skip=YES',
             shaka.net.NetworkingEngine.RequestType.MANIFEST,
             {type:
-              shaka.net.NetworkingEngine.AdvancedRequestType.MASTER_PLAYLIST});
+              shaka.net.NetworkingEngine.AdvancedRequestType.MEDIA_PLAYLIST});
       });
 
       it('skips older segments', async () => {