Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WahWah is broken (NaN, undefined) #18

Closed
1j01 opened this issue May 16, 2015 · 0 comments
Closed

WahWah is broken (NaN, undefined) #18

1j01 opened this issue May 16, 2015 · 0 comments

Comments

@1j01
Copy link

1j01 commented May 16, 2015

On line 1438, this._excursionOctaves is undefined, so the result of the calculation is NaN, giving the error Uncaught TypeError: Failed to set the 'value' property on 'AudioParam': The provided float value is non-finite.
I'm guessing this is a new error that was introduced, and the library was depending on the NaN being ignored, and the useful value being calculated in the setter from the next line
1j01 added a commit to 1j01/guitar that referenced this issue May 16, 2015
@1j01
🐛 Disable WahWah as workaround
e96d80e 
Theodeus/tuna#18
@1j01 1j01 closed this as completed May 16, 2015
1j01 added a commit to 1j01/tuna that referenced this issue May 16, 2015
@1j01
Fix Theodeus#18
f910b74 
Fix Theodeus#18 by checking if calculated values are NaN
@1j01 1j01 mentioned this issue May 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #18 1j01/tuna
1 participant
@1j01