Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up Git: A partition between two topics #28215

Closed
2 of 3 tasks
Ashking-net opened this issue Jun 13, 2024 · 5 comments · Fixed by #28251
Closed
2 of 3 tasks

Setting up Git: A partition between two topics #28215

Ashking-net opened this issue Jun 13, 2024 · 5 comments · Fixed by #28251
Assignees

Comments

@Ashking-net
Copy link

Checks

Describe your suggestion

There is a section in setting up git lesson where a certain section is given for mac users only and the next part is just normal tutorial for setting up git, but it causes problem cause there is no partition between the mac user special tut and normal guide which makes newbies think the next part is also part of mac users Tutorial, which causes huge problem in setting up git

in the image provided there is mac user specfic command and in next line i.e (Step 2.3) many linux user skip this thinking its related to mac user only,which result in them making no SSH key

ss

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-setting-up-git

(Optional) Discord Name

Ashking

(Optional) Additional Comments

No response

@xandora
Copy link
Member

xandora commented Jun 13, 2024

We could make it a note section to give it some contrast with the following step.
image

@Ashking-net
Copy link
Author

Ashking-net commented Jun 16, 2024

yeah that would work

theSamyak added a commit to theSamyak/curriculum that referenced this issue Jun 20, 2024
issue TheOdinProject#28215
In the "Setting Up Git" lesson (setting_up_git.md), added a note section to clearly differentiate macOS-specific commands from general setup instructions.
@theSamyak
Copy link
Contributor

Since no one was assigned and it has been a week, I went ahead and resolved this issue. I apologize for not adhering to the policy of not starting work on open issues without assignment, which @MaoShizhong brought to my attention after I submitted my pull request.

Could you please review the changes this time and confirm if everything looks good on your end? If necessary, I am prepared to revert the changes and resubmit the pull request accordingly. Thankyou.

@MaoShizhong
Copy link
Contributor

Since no one was assigned and it has been a week, I went ahead and resolved this issue. I apologize for not adhering to the policy of not starting work on open issues without assignment, which @MaoShizhong brought to my attention after I submitted my pull request.

Could you please review the changes this time and confirm if everything looks good on your end? If necessary, I am prepared to revert the changes and resubmit the pull request accordingly. Thankyou.

In the future, the process would be to comment on the issue requesting assignment, then waiting to be assigned by a maintainer before opening a PR. In this case, since no one else has requested assignment, I'll assign you. One of the team will get to reviewing your PR in due course.

@theSamyak
Copy link
Contributor

Since no one was assigned and it has been a week, I went ahead and resolved this issue. I apologize for not adhering to the policy of not starting work on open issues without assignment, which @MaoShizhong brought to my attention after I submitted my pull request.
Could you please review the changes this time and confirm if everything looks good on your end? If necessary, I am prepared to revert the changes and resubmit the pull request accordingly. Thankyou.

In the future, the process would be to comment on the issue requesting assignment, then waiting to be assigned by a maintainer before opening a PR. In this case, since no one else has requested assignment, I'll assign you. One of the team will get to reviewing your PR in due course.

Thanks!  I'll keep this in mind. Looking forward to contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants