Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional class loader & Update options in runtime #22

Merged
merged 3 commits into from
Jan 31, 2015

Conversation

ruslan-polutsygan
Copy link
Contributor

Alternative to this PR #20
and merged with this #21

@ruslan-polutsygan
Copy link
Contributor Author

Hi @benja-M-1
I decided to combine 2 pull requests into one. I hope you don't mind.

@ruslan-polutsygan ruslan-polutsygan changed the title Class loader & Update options in runtime Optional class loader & Update options in runtime Jan 27, 2015
@ruslan-polutsygan
Copy link
Contributor Author

Hello @benja-M-1

What do you think about this pull request? Are you going to review and/or merge it?
Let me know please.

Thanks

@benja-M-1
Copy link
Contributor

Hi @ruslan-polutsygan thanks for the PR. I do prefer small PRs but that's fine :)

I'll review later, I can't do it right now.But from what I saw it seems promising. I'll try to do it at the end of the day (Paris time).

Thanks again for your work !

@ruslan-polutsygan
Copy link
Contributor Author

hi
I was just wondering whether it's OK in general or I should continue working with my own fork.
I'm not rushing you. Today - is great :)

@benja-M-1
Copy link
Contributor

In general it's OK :) I do prefer to make the autoload service optional rather than to add an empty class as in #20.

@benja-M-1
Copy link
Contributor

Hi @ruslan-polutsygan, I tester your PR and it seems working perfectly! 🍰

Thank you for your contribution, I merge your PR.

benja-M-1 added a commit that referenced this pull request Jan 31, 2015
Optional class loader & update symfony options in runtime
@benja-M-1 benja-M-1 merged commit 54b8ec7 into theodo:master Jan 31, 2015
@ruslan-polutsygan ruslan-polutsygan deleted the patch-1 branch January 31, 2015 22:33
@ruslan-polutsygan
Copy link
Contributor Author

hi @benja-M-1
That's awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants