-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional class loader & Update options in runtime #22
Conversation
…runtime(base on request). E.g. for dynamic defining current application in legacy symfony1 project.
Hi @benja-M-1 |
Hello @benja-M-1 What do you think about this pull request? Are you going to review and/or merge it? Thanks |
Hi @ruslan-polutsygan thanks for the PR. I do prefer small PRs but that's fine :) I'll review later, I can't do it right now.But from what I saw it seems promising. I'll try to do it at the end of the day (Paris time). Thanks again for your work ! |
hi |
In general it's OK :) I do prefer to make the autoload service optional rather than to add an empty class as in #20. |
Hi @ruslan-polutsygan, I tester your PR and it seems working perfectly! 🍰 Thank you for your contribution, I merge your PR. |
Optional class loader & update symfony options in runtime
hi @benja-M-1 |
Alternative to this PR #20
and merged with this #21