Symfony 3 support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony 3 has deprecated and removed the 'request' service from the DI Container. Instead, it is now required to use the 'request_stack' service. This also changes Travis (to make sure that version 3.0 is also tested) and the tests. Signed-off-by: Jacob Kiers <kiers@comandi.nl>
nicodmf
force-pushed
the
master
branch
10 times, most recently
from
260a0c0
to
a433996
Compare
| { | ||
| $container = $this->prophesize('Symfony\Component\DependencyInjection\ContainerInterface'); | ||
|
|
||
| if (Kernel::MAJOR_VERSION === 2) { |
There was a problem hiding this comment.
The code in this condition is the same as in the else. Can you remove it and change the elseif to an if?
This was referenced May 16, 2016
|
@nicodmf Thanks for finishing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28 and #27 completion