Skip to content
This repository has been archived by the owner on Sep 25, 2022. It is now read-only.

Load several fixtures on same time #11

Merged

Conversation

supertanuki
Copy link
Contributor

No description provided.

@supertanuki
Copy link
Contributor Author

Ping @theofidry

@theofidry
Copy link
Owner

Thanks for the work @supertanuki. But would it be possible to pass a table of fixtures files rather than a string? Like:

Given the following fixtures files are loaded:
| file1 |
| file2 |
...

It would be more readable IMO when having lots of files.

@supertanuki
Copy link
Contributor Author

@theofidry You're right. Thanks. It is fixed.

@theofidry
Copy link
Owner

Removed the preset PSR-0 blocking StyleCI. Could you push an empty commit to trigger a new StyleCI check?

@supertanuki
Copy link
Contributor Author

@theofidry Done ! I updated the readme (not an empty commit...)

@theofidry
Copy link
Owner

Good, just the StyleCI + rebase :)

@supertanuki supertanuki force-pushed the load-several-fixtures-on-same-time branch from 22494b4 to 9951d96 Compare October 26, 2015 15:59
@supertanuki
Copy link
Contributor Author

I rebased to upstream/master. The StyleCI analysis still failed. What's wrong?

@theofidry
Copy link
Owner

Check out the result: https://styleci.io/analyses/zELLvq

You just need to use the short array annotation for it to pass.

@supertanuki
Copy link
Contributor Author

@theofidry thanks, done !

@theofidry
Copy link
Owner

Thank you @supertanuki

theofidry added a commit that referenced this pull request Oct 26, 2015
…-time

Load several fixtures on same time
@theofidry theofidry merged commit dfcb439 into theofidry:master Oct 26, 2015
@theofidry
Copy link
Owner

Erf did not rebase, too late.

@supertanuki
Copy link
Contributor Author

What?

@theofidry
Copy link
Owner

Sorry I was not clear, I meant to rebase to squash the 4 commits into 1. It was my mistake for not checking and fortunately it doesn't have that much of an impact ;)

Anyway merged and tag released!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants