Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts with vscode-styled-component #6

Open
u3u opened this issue Oct 21, 2020 · 3 comments
Open

Conflicts with vscode-styled-component #6

u3u opened this issue Oct 21, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@u3u
Copy link
Contributor

u3u commented Oct 21, 2020

Steps To Reproduce

  1. Installation this plugin
  2. Installation vscode-styled-component

The current behavior

import { css } from '@emotion/core';

// error: } expectedcss(css-rcurlyexpected)
// and syntax highlighting is broken
// it should conflict with styled-jsx's `css.resolve` and `css.global`
const className = css`
  text-align: center;
`;

const Button = () => {
  return (
    <button
      // same problem as above
      css={css`
        text-align: center;
      `}
    />
  );
};

Hope this conflict can be resolved 🙏

@u3u u3u added the bug Something isn't working label Oct 21, 2020
@theoludwig
Copy link
Owner

@u3u Yes, that's a known issue, we can't do anything about that (as I'm aware).
But as a workaround, you can disable/enable the 2 extensions. If you're working with styled-jsx components, enable this extension and disable the other one and the contrary if you're working with styled-components.

@u3u
Copy link
Contributor Author

u3u commented Oct 21, 2020

Because of this problem, i usually combine the two, so it is a trouble for me 😢

@kud
Copy link

kud commented Nov 4, 2020

I've got the same problem. I've disabled this plugin for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants