Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuration file named per component #31

Merged
merged 2 commits into from
Jul 6, 2018

Conversation

toshke
Copy link
Member

@toshke toshke commented Jul 5, 2018

implements #28

If component configuration file contains subcomponent_config_file: key, disregarding the value of this key, configuration won't be merged to master config. Otherwise anything found within yaml file is merged both to master config, and to appropriate component config.

One idea coming out of this implementation is having a cfhighlander scconfigextract command which will generate these files for every subcomponent referenced in the template.

Copy link
Member

@Guslington Guslington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toshke toshke merged commit dcf5b7f into theonestack:develop Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants