This repository has been archived by the owner on Feb 13, 2019. It is now read-only.
add more logging to IA requests #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| instance.id, | ||
| instance.instant_article_id, | ||
| delete.status_code)) | ||
| delete.status_code, | ||
| delete.__dict__)) |
There was a problem hiding this comment.
This might be really noisy. What are specifically looking to get out of this?
There was a problem hiding this comment.
just looking to get all of the request info right now as its 400ing. we can always turn it down later.
There was a problem hiding this comment.
welp if there is no other way then 👍
There was a problem hiding this comment.
You could add it as an additional .debug log, that can then be enabled per-property.
Up to you. LGTM
When you merge I will release this with v2.7.0 (#211)
There was a problem hiding this comment.
I'll just merge this for now, since I imagine this will be a thing I'll remove or at least turn down once we figure out what error info is relevant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mparent61 @benghaziboy