Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Styled Presentional #1797

Merged
merged 3 commits into from
Jun 16, 2023
Merged

feat: Styled Presentional #1797

merged 3 commits into from
Jun 16, 2023

Conversation

DafyddLlyr
Copy link
Contributor

image

Cherry-picked from #1707 🍒

Comment on lines +14 to +16
"@mui/material": "5.13.5",
"@mui/styles": "5.13.2",
"@mui/utils": "5.13.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bump fixed the annoying bug where the "Change" text within a button on the SummaryList wasn't correctly inheriting the font-family.

mui/material-ui#33621

@DafyddLlyr DafyddLlyr requested a review from a team June 15, 2023 14:22
@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Removed vultr server and associated DNS entries

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Lighthouse

buckinhamshire/FOIYNPP testing/canary
performance 0.23 - 0.24 = -0.01 0.34 - 0.31 = 0.03
accessibility 1 - 1 = 0.00 1 - 1 = 0.00
best-practices 1 - 1 = 0.00 0.92 - 0.92 = 0.00
seo 0.88 - 0.89 = -0.01 0.89 - 0.92 = -0.03
pwa 0.7 - 0.7 = 0.00 0.7 - 0.7 = 0.00

@@ -1,4 +1,5 @@
import makeStyles from "@mui/styles/makeStyles";
import Box from "@mui/material/Box";
import { styled } from "@mui/material/styles";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Box & { styled } might be unused imports here?

@DafyddLlyr DafyddLlyr merged commit 1397e34 into main Jun 16, 2023
11 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/styled-presentational branch June 16, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants