Skip to content

Commit

Permalink
buildifier, main .bazelrc, windows ci
Browse files Browse the repository at this point in the history
  • Loading branch information
peakschris committed Jun 17, 2024
1 parent c582a7b commit 2304024
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
9 changes: 9 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
common --enable_bzlmod

common --lockfile_mode=off

# best practice to disable
common --nolegacy_external_runfiles

# off by default on windows, required for this module
startup --windows_enable_symlinks

# off by default on windows, required for this module
common --enable_runfiles
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ jobs:
{"bazelversion": "5.4.0"},
{"bazelversion": "6.4.0"},
]
# our CI only supports linux and macos
exclude_windows: true
integration-tests:
runs-on: ubuntu-latest
steps:
Expand Down
4 changes: 2 additions & 2 deletions multitool/private/multitool.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def _check_version(os):
if int(version[0]) > 7 or (int(version[0]) == 7 and int(version[1]) >= 1):
pass
else:
fail("rules_multitool: windows artifacts require bazel 7.1+; current bazel is "+native.bazel_version)
fail("rules_multitool: windows artifacts require bazel 7.1+; current bazel is " + native.bazel_version)

def _load_tools(rctx):
tools = {}
Expand Down Expand Up @@ -126,7 +126,7 @@ def _env_specific_tools_impl(rctx):
tool_name = tool_name,
cpu = binary["cpu"],
os = binary["os"],
ext = _extension(binary["os"])
ext = _extension(binary["os"]),
)

if binary["kind"] == "file":
Expand Down

0 comments on commit 2304024

Please sign in to comment.