Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include path not properly set in CMake build definitions #67

Closed
docprofsky opened this issue Sep 22, 2017 · 1 comment · Fixed by #182
Closed

Include path not properly set in CMake build definitions #67

docprofsky opened this issue Sep 22, 2017 · 1 comment · Fixed by #182
Labels

Comments

@docprofsky
Copy link

The include path is not properly set in the CMake build definitions. This causes problems when headers are not in the compiler default location. When building, this results in the compiler being unable to find fftw3.h. This can be fixed by passing the include directory(ies) for the libraries to include_directories in CMake.

This is probably not a problem for the developers if their compiler include path covers the headers for all of the dependencies. I use MacOS with MacPorts, which places headers in /opt/local/include, outside of the compiler include path.

I have fixed this with these changes, however this assumes that fftw3.h is in the same location as the rest of the headers.
https://gist.github.com/docprofsky/3ab3e1e4e29ea534548595d9437fa3c7

@awesie
Copy link
Contributor

awesie commented Sep 24, 2017

Using FindPkgConfig and pkg_check_modules is probably the right way to fix the ffw3f and rtlsdr dependencies.

@argilo argilo added the bug label Sep 26, 2017
awesie added a commit to awesie/nrsc5 that referenced this issue Feb 12, 2019
awesie added a commit to awesie/nrsc5 that referenced this issue Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants