Speed up adjust_data and remove fast_cexpf. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bit error rates are the same before & after this change, so I expect it's correct. |
|
Looks like this PR is removing the unsafe math optimizations? If so perhaps that should be removed from the readme as well. |
|
@pclov3r I haven't completely removed |
|
This looks good to me. Feel free to merge with #106 once it is ready. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds on top of #106 and gives another significant speedup simply by moving the expensive complex exponentiations out of the innermost loop of
adjust_data.The speedup is around 12% on Intel, and on my Raspberry Pi 3 the CPU utilization is reduced to around 50%.
Since complex exponentiations are no longer a bottleneck, I removed
fast_cexpf.