Delete default configuration #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `date` to place a timestamp like string to configuration backup files, created when overwriting an existing configuration file.
`config init` will create a new existing file with blank settings. See <theory#47 (comment)>
Since now the configuration files include the timestamp string, the `config delete` command must delete everything that ends in `.backup`.
`config nuke` does the same as `config delete` but allows the user to delete the default configuration file. Now `config delete` does not allow for removal of the default configuration file, but `config nuke` allows for the removal of the default configuration file. Specifying `config delete default` or `config nuke` will provide the same behavior, that is deletion of the default configuration. See <theory#47 (comment)>
Now the command loads the current default configuration and dumps it as the specified file.
Introduction to the new behavior of the `config` subcommands. See <theory#47 (comment)>
|
Shouldn't |
theory
requested changes
Nov 8, 2021
Check for the existance of the configuration file when `config init` is run and avoid re-doing initialization then.
The latter is enough explicit to warn the user to do the deletion.
Remove the `config nuke` references. Explain the workflow of `config init`.
|
I've fixed I need to rebase on other changes before this is ready. |
theory
approved these changes
Nov 9, 2021
Placed also a debug message to explain which version was in use to double check the program has "guessed" the right file.
When trying to delete the default configuration by not specifying the version, the warning message provides more details. Also removed a reference to `nuke`.
Fix documentation. Also, example with a serious editor ;)
Started by theory, removed everywhere for coherence.
|
Seems fine to me, I've run a "normal" |
Last debug message introduction missed an escape sequence that screwed up all the script.
theory
reviewed
Nov 10, 2021
Applied 'sh' and '$' prompt coherently across all the examples. Fixed a few markdown lists here and there. Removed the timestamp from the log outputs.
theory
reviewed
Nov 11, 2021
Use 'sh' only if there are commands without output, use '$' as prompt only when there is an user input and output.
theory
approved these changes
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #47.
Now there are different
configsubcommands:config initcreates always a blank configuration fileconfig writecreates a configuration file with the default configuration if exists, or a blank file otherwiseconfig deletedoes not delete the default configuration file unless explicitly indicated asconfig delete defaultconfig nukedeletes every configuration specified, even the default if not passed as argument.