Modified all diagnostic messages and test descriptions that reference…

… database objects to use `quote_ident()` to quote the names of those objects, rather than emitting them with or without double-quotes in an ad-hoc way as had hitherto been the case.
theory · Feb 4, 2009 · 1433619 · 1433619
1 parent 46c1b97
commit 1433619
Show file tree

Hide file tree

Showing 5 changed files with 159 additions and 156 deletions.
diff --git a/Changes b/Changes
@@ -14,6 +14,10 @@ Revision history for pgTAP
       - Changed default descriptions for column testing functions to refer to
         the columns as the more SQL-standard `schema.table.column` instead of
         `schema.table(column)`.
+      - Modified all diagnostic messages and test descriptions that reference
+        database objects to use `quote_ident()` to quote the names of those
+        objects, rather than emitting them with or without double-quotes in an
+        ad-hoc way as had hitherto been the case.
 
 0.16  2009-02-03T17:37:03
       - Switched from a crazy trinary logic in `is()` and `isnt()` to the use

diff --git a/README.pgtap b/README.pgtap
@@ -2147,7 +2147,6 @@ To Do
   function rather than test files.
 * Fix various column testing functions so that they emit useful diagnostics if
   a column does not exist, like `col_has_default()` does.
-* Use `quote_ident()` to quote all identifiers in diagnostics and descriptions.
 * Useful schema testing functions to consider adding:
   * `has_tablespace()`
   * `has_cast()`