New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theory/semver/#2: Semantic VersioningVersion 2 #7
theory/semver/#2: Semantic VersioningVersion 2 #7
Conversation
…on of SemVer2 work - Some other formerly working unittests do fail now
- Made all unittests work again
- Made all unittests work again
- Made all unittests work again
Thank you! Would you take a look at fixing the failures on older Perls? |
- Made all unittests work again
Done :-) Remark: I added unittests to verify the implementation against specification (used extended ordering example from http://semver.org/spec/v2.0.0.html - Point 11 ) |
Are there any specific reasons you don't accept my pull request? |
Only a lack of time! |
Looks like you removed the ability for |
Also, looking at a couple of issues we had with pg-semver, there's theory/pg-semver#19, which covers metadata appearing after a plus ( |
Hrm, I removed the merge, but this issue isn't updating. :-( Might have to open a new PR after addressing the issues above. Sorry about that. |
Hi theory, after you have merged now: are there still open things I have to/should do/fix? |
Yeah, but I'll do the merge again and you can work from that. Then there's this. |
This commits are implementing #2
One thing I was not sure how to implement (not a technical problem - but I couldn't decide whats the correct implementation):
Versionstrings with NO Hyphen between Version and PreRelease are NO longer accepted as valid SemVers (see 9. in http://semver.org/spec/v2.0.0.html) - as Hyphens are required according specification to separate Version from PreRelease. In SemVer 1.0 no Hyphen was required (see 4.) in http://semver.org/spec/v1.0.0.html). (Versionstrings like 1.2.3b are NO longer valid SemVer now)
This is kind of inconsequent, as the Versionpart according to 2.) http://semver.org/spec/v2.0.0.html has to be in form "X.Y.Z" - but the current implementation still accepts incomplete versions like "1" or "1.0" ("X.Y.Z" was already required by http://semver.org/spec/v1.0.0.html Point 2.) - but your implementation already does not consider this)
I adapted the tests to reflect the changes from SemVer 1.0 to 2.0