Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theory/semver/#2: Semantic VersioningVersion 2 #7

Merged
merged 8 commits into from Feb 24, 2017
Merged

theory/semver/#2: Semantic VersioningVersion 2 #7

merged 8 commits into from Feb 24, 2017

Conversation

hoppfrosch
Copy link
Collaborator

This commits are implementing #2

One thing I was not sure how to implement (not a technical problem - but I couldn't decide whats the correct implementation):
Versionstrings with NO Hyphen between Version and PreRelease are NO longer accepted as valid SemVers (see 9. in http://semver.org/spec/v2.0.0.html) - as Hyphens are required according specification to separate Version from PreRelease. In SemVer 1.0 no Hyphen was required (see 4.) in http://semver.org/spec/v1.0.0.html). (Versionstrings like 1.2.3b are NO longer valid SemVer now)
This is kind of inconsequent, as the Versionpart according to 2.) http://semver.org/spec/v2.0.0.html has to be in form "X.Y.Z" - but the current implementation still accepts incomplete versions like "1" or "1.0" ("X.Y.Z" was already required by http://semver.org/spec/v1.0.0.html Point 2.) - but your implementation already does not consider this)

I adapted the tests to reflect the changes from SemVer 1.0 to 2.0

@hoppfrosch hoppfrosch changed the title Feature/theory/semver/#2: Semantic VersioningVersion 2 theory/semver/#2: Semantic VersioningVersion 2 Apr 8, 2016
@theory
Copy link
Owner

theory commented Apr 12, 2016

Thank you! Would you take a look at fixing the failures on older Perls?

@hoppfrosch
Copy link
Collaborator Author

hoppfrosch commented Apr 18, 2016

Done :-)

Remark: I added unittests to verify the implementation against specification (used extended ordering example from http://semver.org/spec/v2.0.0.html - Point 11 )

@hoppfrosch
Copy link
Collaborator Author

Are there any specific reasons you don't accept my pull request?

@theory
Copy link
Owner

theory commented Feb 14, 2017

Only a lack of time!

@theory theory merged commit 8d0290a into theory:master Feb 24, 2017
@theory
Copy link
Owner

theory commented Feb 24, 2017

Looks like you removed the ability for declare() to upgrade semver 1.0.0-beta versions to v2.0.0 semvers. For example, you commented out the testing of 1.2.02b and the like. Can you restore those, just for declare(), so that we have a bit more backward compatibility?

@theory
Copy link
Owner

theory commented Feb 24, 2017

Also, looking at a couple of issues we had with pg-semver, there's theory/pg-semver#19, which covers metadata appearing after a plus (+), and theory/pg-semver#23, which covers some of the formatting and sort ordering of metadata.

@theory
Copy link
Owner

theory commented Feb 24, 2017

Hrm, I removed the merge, but this issue isn't updating. :-( Might have to open a new PR after addressing the issues above. Sorry about that.

@hoppfrosch
Copy link
Collaborator Author

Hi theory,

after you have merged now: are there still open things I have to/should do/fix?

@hoppfrosch hoppfrosch deleted the feature/theory/semver/#2-Semver2 branch February 27, 2017 05:44
@theory
Copy link
Owner

theory commented Feb 27, 2017

Yeah, but I'll do the merge again and you can work from that. Then there's this.

@hoppfrosch hoppfrosch restored the feature/theory/semver/#2-Semver2 branch March 2, 2017 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants