Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install : overwriting 'App::Sqitch::extends' #180

Closed
GeJ opened this issue Sep 18, 2014 · 9 comments
Closed

Unable to install : overwriting 'App::Sqitch::extends' #180

GeJ opened this issue Sep 18, 2014 · 9 comments
Assignees
Labels
Milestone

Comments

@GeJ
Copy link

GeJ commented Sep 18, 2014

I tried to install App::Sqitch on a FreeBSD 9.3/perl 5.18.2 and had a bunch of errors like these :

t/tag.t ............. 1/27 
#   Failed test 'no warnings'
#   at /home/geraud/local/lib/perl5/Test/NoWarnings.pm line 45.
# There were 1 warning(s)
#       Previous test 0 ''
#       Overwriting existing sub 'App::Sqitch::extends' with sub 'extends' exported by Type::Utils at /usr/home/geraud/.cpanm/work/1411080422.31293/App-Sqitch-0.996/blib/lib/App/Sqitch.pm line 18.
#  at /home/geraud/local/lib/perl5/Exporter/Tiny.pm line 222.
#       Exporter::Tiny::_exporter_install_sub("Type::Utils", "extends", HASH(0x804a11108), HASH(0x8049f3fd8), CODE(0x803e2bca8)) called at /home/geraud/local/lib/perl5/Exporter/Tiny.pm line 55
#       Exporter::Tiny::import("Type::Utils", "-all") called at /usr/home/geraud/.cpanm/work/1411080422.31293/App-Sqitch-0.996/blib/lib/App/Sqitch.pm line 18
#       App::Sqitch::BEGIN() called at /usr/home/geraud/.cpanm/work/1411080422.31293/App-Sqitch-0.996/blib/lib/App/Sqitch.pm line 18
#       eval {...} called at /usr/home/geraud/.cpanm/work/1411080422.31293/App-Sqitch-0.996/blib/lib/App/Sqitch.pm line 18
#       require App/Sqitch.pm called at t/tag.t line 11
#       main::BEGIN() called at /usr/home/geraud/.cpanm/work/1411080422.31293/App-Sqitch-0.996/blib/lib/App/Sqitch.pm line 18
#       eval {...} called at /usr/home/geraud/.cpanm/work/1411080422.31293/App-Sqitch-0.996/blib/lib/App/Sqitch.pm line 18
# 
# Looks like you failed 1 test of 27.

At first I would say that it comes from Moo and Type::Utils both exporting an 'extends' method, but looking at the CPAN Testers site I can see I'm pretty much the only one having this issue. All my packages seem up-to-date (at least according to cpan-outdated).

Also, while Test::NoWarnings is loaded in pretty much all the test files, only the following ones are reported as failing :

Test Summary Report
-------------------
t/base.t          (Wstat: 256 Tests: 242 Failed: 1)
  Failed test:  242
  Non-zero exit status: 1
t/blank.t         (Wstat: 256 Tests: 34 Failed: 1)
  Failed test:  34
  Non-zero exit status: 1
t/change.t        (Wstat: 256 Tests: 85 Failed: 1)
  Failed test:  85
  Non-zero exit status: 1
t/changelist.t    (Wstat: 256 Tests: 351 Failed: 1)
  Failed test:  351
  Non-zero exit status: 1
t/config.t        (Wstat: 256 Tests: 344 Failed: 1)
  Failed test:  344
  Non-zero exit status: 1
t/linelist.t      (Wstat: 256 Tests: 28 Failed: 1)
  Failed test:  28
  Non-zero exit status: 1
t/pragma.t        (Wstat: 256 Tests: 10 Failed: 1)
  Failed test:  10
  Non-zero exit status: 1
t/tag.t           (Wstat: 256 Tests: 27 Failed: 1)
  Failed test:  27
  Non-zero exit status: 1

I'm not quite sure where to look at after that. Do you have any idea?

@GeJ
Copy link
Author

GeJ commented Sep 18, 2014

Update :
Loading Test::NoWarnings after App::Sqitch* modules (or the BEGIN block that use_ok() them) seems to fix the failures. I still have the warnings showing, but at least they aren't fatal anymore. Would you like me to write a patch?

@theory
Copy link
Collaborator

theory commented Sep 19, 2014

Hrm. Do you have the latest versions of Moo and Type::Utils?

@theory theory added the bug label Sep 19, 2014
@theory theory self-assigned this Sep 19, 2014
@theory theory added this to the v1.0.0 milestone Sep 19, 2014
@GeJ
Copy link
Author

GeJ commented Sep 19, 2014

# perl -Moo -MType::Utils -E 'say $Moo::VERSION; say $Type::Utils::VERSION'
1.006
1.000004

Looks like it.

@theory theory closed this as completed in c79616d Sep 19, 2014
@theory
Copy link
Collaborator

theory commented Sep 19, 2014

Let me know if that fixes the issue for you.

@GeJ
Copy link
Author

GeJ commented Sep 19, 2014

I applied the patch against 0.996 tarball, and all tests were successful.
Thank you very much.

@joevandyk
Copy link

@theory you know if cpan will get updated soon with this fix? (can't install from cpan without it)

@theory
Copy link
Collaborator

theory commented Sep 24, 2014

I hope to get back to some Sqitch stuff next week.

@phillipadsmith
Copy link

/subscribing

@theory
Copy link
Collaborator

theory commented Oct 20, 2014

Working on #151 and #153 now. Should finish and release this week, I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants