Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use named types in pg_tapgen generated function body tests #34

Merged
merged 3 commits into from Oct 24, 2020
Merged

Use named types in pg_tapgen generated function body tests #34

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23fe172
Only output unique function names when generating functions_are tests.
deathwish Aug 29, 2020
f04d503
Use type names rather than oids in generated function body md5 tests.
deathwish Aug 29, 2020
5a0e0c5
Enforce a fully stable sort order on generated function body tests.
deathwish Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions bin/pg_tapgen
View file
Open in desktop
Expand Up @@ -251,27 +251,27 @@ sub sequences_are {
sub functions_are {
my $schema = shift;
my $sth = $dbh->prepare(q{
SELECT p.proname, md5(p.prosrc) as md5, proargtypes::text
SELECT p.proname, md5(p.prosrc) as md5, oidvectortypes(proargtypes) as proargs
FROM pg_catalog.pg_proc p
JOIN pg_catalog.pg_namespace n ON p.pronamespace = n.oid
WHERE n.nspname = ?
ORDER BY p.proname
});
my $allfuncs = $dbh->selectall_arrayref($sth, undef, $schema);
return unless $allfuncs && @$allfuncs;
my @funcs=map{$_->[0]} @$allfuncs;
my %funcs=map{$_->[0] => undef} @$allfuncs;
deathwish marked this conversation as resolved.
Show resolved Hide resolved
print "SELECT functions_are('$schema', ARRAY[\n '",
join("',\n '", @funcs),
join("',\n '", sort keys %funcs),
"'\n]);\n\n";
$total_tests++;
for my $row (@$allfuncs) {
my ($proname, $md5, $proargs)=@$row;
print qq{SELECT is(md5(p.prosrc), '$md5', 'Function $proname body should match checksum')
FROM pg_catalog.pg_proc p
JOIN pg_catalog.pg_namespace n ON p.pronamespace = n.oid
WHERE n.nspname = '$schema'
AND proname = '$proname'
AND proargtypes::text = '$proargs';\n\n};
print qq{SELECT is(md5(p.prosrc), '$md5', 'Function $schema.$proname($proargs) body should match checksum')
FROM pg_catalog.pg_namespace n
LEFT JOIN pg_catalog.pg_proc p ON p.pronamespace = n.oid
AND proname = '$proname'
AND oidvectortypes(proargtypes) = '$proargs'
WHERE n.nspname = '$schema';\n\n};
$total_tests++;
}
#
Expand Down