Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Standardize auto-linking respective libs in .modulemaps #18

Closed
L1ghtmann opened this issue May 30, 2023 · 2 comments
Closed

Comments

@L1ghtmann
Copy link
Member

L1ghtmann commented May 30, 2023

What are the steps to reproduce this issue?

N/A

What happens?

N/A

What were you expecting to happen?

N/A

Any logs, error output, etc?

Any other comments?

Note: I am not well versed on clang modules/module maps.

Currently, 8/9 of the module maps Theos provides auto-link their respective libraries. The only module map currently in this repo -- Alderis' -- does not and those in the soon-to-be-merged Orion lib pr do not. This seems like something worth standardizing so that we can have consistent module usage across provided libraries/frameworks.

What versions of software are you using?

Operating System:

Toolchain Version:

SDK Version:

@leptos-null
Copy link
Member

I believe this discrepancy is caused by the same underlying difference described in theos/headers#83: frameworks do not need to specify the name of their binary since they are self-contained.

@L1ghtmann
Copy link
Member Author

Ah, gotcha. Thanks for the clarification!

@L1ghtmann L1ghtmann closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants