Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac users with coreutils from brew can't package due to du not taking the same args #230

Closed
uroboro opened this issue Feb 8, 2017 · 4 comments

Comments

@uroboro
Copy link
Member

uroboro commented Feb 8, 2017

What are the steps to reproduce this issue?

  1. Make project
  2. make package

What happens?

Package is not built.

What were you expecting to happen?

Package being built.

Any logs, error output, etc?

make[2]: Nothing to be done for `internal-library-compile'.
> Making stage for tweak Test…
du: invalid option -- 'I'
Try 'du --help' for more information.
dpkg-deb: error: parsing file '/Users/username/Desktop/test/.theos/_/DEBIAN/control' near line 9 package 'com.my.testtweak:iphoneos-arm':
end of file before value of field 'Installed-Size' (missing final newline)
make: *** [internal-package] Error 2

Any other comments?

What versions of software are you using?

Operating System: macOS

Toolchain Version: N/A

SDK Version: N/A

@uroboro
Copy link
Member Author

uroboro commented Feb 8, 2017

Given that we already depend on dpkg and ldid on this platform, we could potentially depend on coreutils as well if we can't distinguish which du is going to be used.

Relevant makefile: https://github.com/theos/theos/blob/master/makefiles/platform/Darwin.mk#L16

@DHowett
Copy link
Collaborator

DHowett commented Feb 8, 2017 via email

@uroboro
Copy link
Member Author

uroboro commented Feb 8, 2017

@kirb commented that it might have been an issue on how it was installed, using --with-default-names which would remove the g prefix.

@kirb
Copy link
Collaborator

kirb commented Feb 8, 2017

Homebrew does prefix coreutils with g as the others do, but it also provides a feature to enable using them without a prefix. (Actually, there’s no --with-default-names for coreutils as @uroboro said I said; some other dupe formulae have that though.)

That said, we do prefer gdu over du, and gdu should definitely still be in the path unless the user has done a brew unlink coreutils or something else strange. This issue was sprouted from this thread; I’m not confident the poster is aware of what they’ve done to cause it.

I don’t think we should consider this a bug. People should be well aware that various things will break when assumptions about the environment are changed.

@kirb kirb closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants