Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more toggles #847

Closed
John-Gee opened this issue Feb 8, 2023 · 16 comments
Closed

Add more toggles #847

John-Gee opened this issue Feb 8, 2023 · 16 comments

Comments

@John-Gee
Copy link

John-Gee commented Feb 8, 2023

Thank you!

@theotherp
Copy link
Owner

Will look into it. I might have to change the wrappers anyway.

@theotherp
Copy link
Owner

theotherp commented Feb 8, 2023

What's the purpose of the first one? Looks like you could fix it by using the proper folder structure?

@theotherp
Copy link
Owner

I read the comments on https://aur.archlinux.org/packages/nzbhydra2-nojava-bin. Not sure I understand everything but all right.

NZBHYDRA_DISABLE_UPDATE_ON_SHUTDOWN
NZBHYDRA_FORCE_GENERIC
NZBHYDRA_USE_BASE_PATH_FOR_LIBS

Please verify:
nzbhydra2wrapperPy3.zip

@theotherp
Copy link
Owner

If it's not right just adapt it and post it.

@John-Gee
Copy link
Author

John-Gee commented Feb 8, 2023

Thank you for the quick update!

Are you sure about the wrapper you posted? diff shows no difference with the one from 5.1.2.

@theotherp
Copy link
Owner

Oops
nzbhydra2wrapperPy3.zip

@John-Gee
Copy link
Author

John-Gee commented Feb 8, 2023

Yup that works!

I also needed the NZBHYDRA_USE_BASE_PATH . :)

A few notes:

  • readme = os.path.join(basePath, "readme.md") could go behind the check for the env var, not a big deal though
  • I feel like I have to set NZBHYDRA_USE_BASE_PATH to false, whether I have to set NZBHYDRA_USE_BASE_PATH_FOR_LIBS to true. I know you just check if they're set, but it's the names.

Thank you!

@theotherp
Copy link
Owner

I've renamed it to NZBHYDRA_SKIP_BASE_PATH_CHECK.

@John-Gee
Copy link
Author

John-Gee commented Feb 9, 2023

Thank you!

@theotherp
Copy link
Owner

There it is.

@John-Gee
Copy link
Author

Hey, I could be wrong but it does not seem that .5 has NZBHYDRA_FORCE_GENERIC or anything similar. Did you change that?

Thank you!

@John-Gee
Copy link
Author

Actually updating to .6, I realize another toggle is missing. Those are:

NZBHYDRA_DISABLE_WRAPPER_CHECK
NZBHYDRA_FORCE_GENERIC

(since FORCE_GENERIC needed a value, maybe that was the wrong name too?)

Thank you!

@theotherp
Copy link
Owner

NZBHYDRA_DISABLE_WRAPPER_CHECK is in there but the main process doesn't inherit the environment variables from the wrapper.
NZBHYDRA_SKIP_BASE_PATH_CHECK is indeed missing. No idea what happened there.

Sorry about that.

@theotherp theotherp reopened this Feb 24, 2023
@theotherp
Copy link
Owner

I have multiple copies of the file, only one being tracked by git. I had changed the wrong one :-(

@theotherp
Copy link
Owner

Does it work now?

@John-Gee
Copy link
Author

John-Gee commented Mar 5, 2023

Yup it's fine, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants