-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more toggles #847
Comments
Will look into it. I might have to change the wrappers anyway. |
What's the purpose of the first one? Looks like you could fix it by using the proper folder structure? |
I read the comments on https://aur.archlinux.org/packages/nzbhydra2-nojava-bin. Not sure I understand everything but all right.
Please verify: |
If it's not right just adapt it and post it. |
Thank you for the quick update! Are you sure about the wrapper you posted? diff shows no difference with the one from 5.1.2. |
Yup that works! I also needed the NZBHYDRA_USE_BASE_PATH . :) A few notes:
Thank you! |
I've renamed it to |
Thank you! |
There it is. |
Hey, I could be wrong but it does not seem that .5 has NZBHYDRA_FORCE_GENERIC or anything similar. Did you change that? Thank you! |
Actually updating to .6, I realize another toggle is missing. Those are: NZBHYDRA_DISABLE_WRAPPER_CHECK (since FORCE_GENERIC needed a value, maybe that was the wrong name too?) Thank you! |
Sorry about that. |
I have multiple copies of the file, only one being tracked by git. I had changed the wrong one :-( |
Does it work now? |
Yup it's fine, thanks a lot! |
Following Allow bypassing checksum with a flag #839 I'm creating a new FR for more toggles.
Instead of bothering you with text, I'm hopeful code will make more sense so here are the patches that we carry which would be nice as toggles instead:
https://aur.archlinux.org/cgit/aur.git/plain/wrapper-remove-base-path-checks.patch?h=nzbhydra2-nojava-bin
https://aur.archlinux.org/cgit/aur.git/plain/wrapper-remove-release-type-detection.patch?h=nzbhydra2-nojava-bin
https://aur.archlinux.org/cgit/aur.git/plain/wrapper-remove-update-support.patch?h=nzbhydra2-nojava-bin
I'd rather be as close to upstream as possible without carrying extra patches.
It's possible other package maintainers would like those too.
Thank you!
The text was updated successfully, but these errors were encountered: