Move challenge contexts to the session #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| )) { | ||
| if (!session.challengeContexts) { | ||
| log(LogLevel.WARN, "Session does not have challenge contexts.") | ||
| log(LogLevel.WARN, "Challenges will be disabled!") |
There was a problem hiding this comment.
When mastery progression exists, it may be wise to change to "Progression will be disabled" as the global challenges should be tracked by the same system as normal challenges.
AnthonyFuller
approved these changes
Nov 20, 2022
|
Appears to have broken saving al together. I'll investigate where it comes from. EDIT: Hmm, must have been a fluke. Did a clean check-out, did a test-run with a contract, saved midway, closed the game, closed the server, restarted, could continue where I left off properly without being kicked offline. EDIT 2: Tested destination with actual challenges. All seems good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32