Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New challenge pack: Butcher's Delight #411

Merged
merged 13 commits into from
Apr 6, 2024

Conversation

suanjiansalt
Copy link
Contributor

@suanjiansalt suanjiansalt commented Apr 4, 2024

closes #410 .

  • Change the acquisition method of The Butcher Suit, add butcher's saw and meathook.
  • Add the acquisition methods of The Purple Streak Suit and The Florida Fit w. Gloves (for H2).

@suanjiansalt suanjiansalt changed the title Change acquisition method of butcher and purple streak suits Change acquisition method of some suits Apr 4, 2024
@suanjiansalt
Copy link
Contributor Author

Checked your change committed yesterday... Does components/candle/challengeService.ts needs an additional change? Like here:

  public challengePacks: { [key: string]: ChallengePack } = {
      "argentum-pack": {
          Name: "UI_MENU_PAGE_PROFILE_CHALLENGES_CATEGORY_PACK_ARGENTUM",
          Description: "",
          GameVersions: ["h3"],
          Image: "images/challenges/categories/packargentum/tile.jpg",
          Icon: "challenge_category_feats",
      },
      "argon-pack": {
          Name: "UI_MENU_PAGE_PROFILE_CHALLENGES_CATEGORY_PACK_ARGON",
          Description: "",
          GameVersions: ["h3"],
          Image: "images/challenges/categories/packargon/tile.jpg",
          Icon: "challenge_category_feats",
      },
      // add my pack object
  }

@AnthonyFuller
Copy link
Contributor

I meant to flag that, yes. If you want it to show on the Career -> Challenges menu it'll have to be added there. @RDIL changed that to a map in a commit before release.

@suanjiansalt suanjiansalt marked this pull request as ready for review April 4, 2024 13:57
@AnthonyFuller
Copy link
Contributor

I'll review this after a PR has been made for the images.

contractdata/SGAIL/_SGAIL_CHALLENGES.json Outdated Show resolved Hide resolved
resources/locale.json Outdated Show resolved Hide resolved
@RDIL RDIL changed the base branch from v7 to master April 4, 2024 18:00
@RDIL RDIL changed the title Change acquisition method of some suits feat: New challenge pack: Butcher's Delight Apr 4, 2024
@suanjiansalt suanjiansalt added the challenges Related to in-game challenges. label Apr 6, 2024
@AnthonyFuller AnthonyFuller merged commit b3d54c6 into thepeacockproject:master Apr 6, 2024
2 checks passed
AnthonyFuller added a commit that referenced this pull request Apr 6, 2024
* add pack and change drops

* run prettier

* introduce florida suit with gloves to elusive target miami challenge

* add cq challenge and minor fixes

* add entrance

* change wrapper image

* minor fixes

* from constant to smith

* locale changes

* add no spotted to italy challenge

* took its condition apart and now hook challenge will popup in mission

* Update cheesecake locale

---------

Co-authored-by: AnthonyFuller <anthony@hitmods.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenges Related to in-game challenges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change some challenge drops
2 participants