Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(compat): Reintroduce smf checks in controller #416

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Yanrishatum
Copy link
Contributor

Adds back the addClientSideModDependency and modIsInstalled to controller instance with an explicit deprecation warning in console and an path to intended API.

Reasoning provided in Discord;

Imma be honest, "months" is a very small timeframe and the way it currently handles breaking change is not very obvious to plugin developers. I'm all for better API, but breaking changes like that seem excessive.
My proposal woudl be to bring those back with one of:

  • Log a warning about deprecation (and show intended API), but retain bad behavior.
  • Log an error about deprecation and always return not installed
  • Throw an error with more descriptive message pointing at the right API.

Not saying to keep it indefinitely, but at least provide a better window to spot the deprecation issue.

@RDIL RDIL merged commit ed02333 into thepeacockproject:v7 Apr 5, 2024
4 of 5 checks passed
@Yanrishatum Yanrishatum deleted the restore_mod_compat branch April 5, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants