Livesplit - Provide a TimeCalc URL for Season/Trilogy speedruns #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex73630
force-pushed
the
livesplit-timecalc
branch
from
335510e
to
d1b7255
Compare
fu5ha
requested changes
Nov 27, 2022
There was a problem hiding this comment.
Very cool idea, I support it! Unfortunately, there's an important corner case that isn't handled yet:
If you "complete" a mission, but have red guns, or otherwise didn't complete your objective, the autosplitter allows you to just restart the level and it will unsplit. The timecalc info tracking should support this case as well. See lines 111-130 for where this is handled for livesplit itself (i.e. where the unsplit call happens). You should be able to just get the latest entry in the timeCalcEntries and set its isComplete to false, if I'm not missing anything.
alex73630
force-pushed
the
livesplit-timecalc
branch
from
d1b7255
to
3635ec7
Compare
- Return 2 URLs if there is not enough lines to fit all the resets - Print time as mm:ss when time is over 60s - Include resetMinimum and time under 1s logics in TimeCalc output - Handle unsplit logic in TimeCalc
fu5ha
requested changes
Dec 8, 2022
RDIL
approved these changes
Dec 9, 2022
- Updated _addMissionTime to always return a floored time - Updated _formatSecondsToTime to better match other code patterns in module - Removed debug logs entries
|
I updated the code following @fu5ha recommendations and now waiting on approval. Thanks everyone for the feedback! |
alex73630
changed the title
fu5ha
approved these changes
Dec 12, 2022
scrungofan
pushed a commit
to scrungofan/Peacock
that referenced
this pull request
Dec 25, 2022
…eacockproject#42) * wip(livesplit): store individual times for timecalc sheet * feat(livesplit): generate timecalc link at run end * chore: move livesplit typings in its own types file * feat(livesplit): complete timecalc feature - Return 2 URLs if there is not enough lines to fit all the resets - Print time as mm:ss when time is over 60s - Include resetMinimum and time under 1s logics in TimeCalc output - Handle unsplit logic in TimeCalc * feat(livesplit): couple of changes over pr comments - Updated _addMissionTime to always return a floored time - Updated _formatSecondsToTime to better match other code patterns in module - Removed debug logs entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating and printing a TimeCalc link as required for Season/Full game runs from Speedrun.com
This will print a link like this one in the console, ready to be submitted, using Livesplit output.
https://solderq35.github.io/fg-time-calc/?mode=0&fs3=1&ft2=1&f3t1=1&f4t0=1&d=:&o1=1&fps=&t1=49&c1=Paris&t2=106&c2=Sapienza&t3=94&c3=Marrakesh&t4=79&c4=Bangkok&t5=76&c5=Colorado&t6=45&c6=Hokkaido&t8=74&c8=Sapienza%20reset%201&t9=75&c9=Sapienza%20reset%202&t10=42&c10=Sapienza%20reset%203&t11=42&c11=Sapienza%20reset%204&t12=27&c12=Colorado%20reset%201&t13=38&c13=Hokkaido%20reset%201