Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: official -> peacock progression transfer #426

Merged
merged 23 commits into from
Apr 20, 2024
Merged

Conversation

AnthonyFuller
Copy link
Contributor

@AnthonyFuller AnthonyFuller commented Apr 11, 2024

As title. Thank's to @vitphire's fork which had an early version of progression transfer, it was used for reference.

This PR updates the latest profile version to version 2. This restructures how we store action xp for sublocations and also fixes the player profile page.

We make the UserDefault contain an empty object, saves having to add all the locations. They're only added when XP is actually gained in that sublocation, this mimics official behaviour.
@AnthonyFuller AnthonyFuller requested a review from RDIL April 11, 2024 14:29
@AnthonyFuller
Copy link
Contributor Author

This PR is currently awaiting web ui changes by @RDIL.

Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@RDIL RDIL marked this pull request as ready for review April 19, 2024 16:34
@RDIL RDIL merged commit beb610c into master Apr 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants