Reworking of challenge system #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
| @@ -811,51 +737,49 @@ export class ChallengeService extends ChallengeRegistry { | |||
| gameVersion: GameVersion, | |||
| userId: string, | |||
| ): CompiledChallengeTreeData { | |||
| let contract | |||
| let contract: MissionManifest | null | |||
|
|
|||
| // TODO: Properly get escalation groups for this | |||
| if (challenge.Type === "contract") { | |||
| contract = this.controller.resolveContract( | |||
| challenge.InclusionData?.ContractIds?.[0] || "", | |||
| ) | |||
|
|
|||
| // This is so we can remove unused data and make it more like official - AF | |||
There was a problem hiding this comment.
This should be investigated as to see whether the format matches official, I have a strong suspicion it may not 100% match. (I remember half arsing the format as it was a mess)
EDIT: The line I selected to add this comment, was on my comment, not your change.
AnthonyFuller
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talked about in #45
Just opening for initial thoughts - haven't even tested it yet