Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for SMF server replacement compatibility #55

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

atampy25
Copy link
Contributor

This is currently just so that Cirrus will build it for me, since Peacock fails to build with a series of bizarre errors whenever I try

@atampy25 atampy25 marked this pull request as ready for review December 12, 2022 04:35
@atampy25 atampy25 added the new feature Addition of a new feature, or request for a new feature. label Dec 12, 2022
Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment, it LGTM.

components/controller.ts Outdated Show resolved Hide resolved
@RDIL RDIL removed the request for review from musicalmushr00m December 13, 2022 03:06
@thepeacockproject thepeacockproject deleted a comment from atampy25 Dec 13, 2022
@thepeacockproject thepeacockproject deleted a comment from atampy25 Dec 13, 2022
Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RDIL RDIL merged commit 6759f58 into thepeacockproject:v5 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Addition of a new feature, or request for a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants