Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Challenge completion and level completion percentage display #79

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Add Challenge completion and level completion percentage display #79

merged 2 commits into from
Jan 12, 2023

Conversation

moonysolari
Copy link
Member

@moonysolari moonysolari commented Jan 12, 2023 •
edited
Loading

  • The "CHALLENGE COMPLETION" ratio and the "TOTAL COPMLETION" percentage now display the correct data at the bottom on the Destinations page, as well as on the page for each location.
  • The "number of challenges vs completed challenges" bar, "number of mission stories vs completed mission stories" bar, and completion percentage all display the correct data on the bottom right on the scoring page now.
  • This PR is fully compatible with but does not depend on Update season 1 challenges and add challenges for the rest of the locations #77, including sniper missions.

@moonysolari moonysolari self-assigned this Jan 12, 2023
@moonysolari moonysolari added challenges Related to in-game challenges. progression Related to the gaining of mastery and other in-game progress. ui Related to the game's menus. new feature Addition of a new feature, or request for a new feature. labels Jan 12, 2023
RDIL
RDIL reviewed Jan 12, 2023
View reviewed changes
components/scoreHandler.ts Outdated Show resolved Hide resolved
RDIL
RDIL approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge, suggestion is optional.

@moonysolari @RDIL
Update components/scoreHandler.ts
9b65fa1 
Co-authored-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: moonysolari <118079569+moonysolari@users.noreply.github.com>
@moonysolari moonysolari merged commit b1dfdb8 into thepeacockproject:v6 Jan 12, 2023
@moonysolari moonysolari deleted the challenge-completion branch January 12, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDIL RDIL RDIL approved these changes

Assignees

@moonysolari moonysolari

Labels
challenges Related to in-game challenges. new feature Addition of a new feature, or request for a new feature. progression Related to the gaining of mastery and other in-game progress. ui Related to the game's menus.
Projects
Challenges & Progression
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moonysolari @RDIL