New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a UI detail for the Challenges tab on the planning page #95

Merged

AnthonyFuller merged 1 commit into thepeacockproject:v6 from moonysolari:challenge-planning-fix

Jan 28, 2023

Member

moonysolari commented Jan 28, 2023

Removes the link to the corresponding mission under challenge tiles for the CHALLENGES tab on the planning page, to match the behavior on official servers. This bug was mentioned in Known issues in v6.0.0 alpha-1 #90.
The link was previously not bugging in H3 but bugging in H2 (see screenshot). However, it should not be shown at all for the planning page.
Whether the link is shown on other pages or not is not affected.


          Fix planning page challenges ui

d5eb967

moonysolari added challenges h2 labels

moonysolari self-assigned this

moonysolari added the ui label

AnthonyFuller approved these changes

View reviewed changes

Contributor

AnthonyFuller left a comment

LGTM.

AnthonyFuller merged commit 7b4e417 into thepeacockproject:v6

moonysolari deleted the challenge-planning-fix branch

January 28, 2023 22:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment