Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the legacy contract downloader and improve options related to it #96

Merged
merged 9 commits into from
Jan 28, 2023

Conversation

moonysolari
Copy link
Member

  • The legacyContractDownloader and officialAuthentication options toggle the same thing according to their descriptions. So, the latter is removed and the former is used in its stead.
  • Fixed the legacy contract downloader for h3 by fixing the URL.
  • Redid the logics regarding the contract downloaders such that
    • H1 and H2 will always use the legacy contract downloader, regardless of the value of legacyContractDownloader, because this is the only downloader they can use.
    • H3 will use the legacy contract downloader if legacyContractDownloader === true, and the HITMAPS downloader otherwise.
    • scpc will not use any downloader.
  • Added a caveat for userAuths because it will only be non-empty if the legacy contract downloader is used.
  • Removed redundant checks for location IDs because they no longer exist after Update H2LocationsData.json #92.

@moonysolari moonysolari added the contracts mode Related to contracts mode. label Jan 28, 2023
@moonysolari moonysolari self-assigned this Jan 28, 2023
Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against this change. I can't remember the exact reason why, but it'll come back to me.

@moonysolari moonysolari requested a review from RDIL January 28, 2023 20:45
@RDIL RDIL merged commit c617a23 into thepeacockproject:v6 Jan 28, 2023
@moonysolari moonysolari deleted the legacy-downloader-fix branch January 28, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts mode Related to contracts mode.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants