fix(poulestructure): make readonly

thepercival · Aug 6, 2024 · 7f1a18c · 7f1a18c
1 parent 3488663
commit 7f1a18c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/domain/Sport/Variant/WithNrOfPlaces/Against/GamesPerPlace.php b/domain/Sport/Variant/WithNrOfPlaces/Against/GamesPerPlace.php
@@ -103,10 +103,8 @@ public function allWithSameNrOfGamesAssignable(Side|null $side = null): bool
         );
     }
 
-
-
     public function getMinNrOfGamesPerPlace(): int {
-        return $this->sportVariant->getNrOfGamesPerPlace() - ($this->getDeficit() ? 1 : 0);
+        return $this->sportVariant->getNrOfGamesPerPlace() - (($this->getDeficit() > 0) ? 1 : 0);
     }
 
     public function getMaxNrOfGamesPerPlace(): int {

diff --git a/tests/cases/CounterTest.php b/tests/cases/CounterTest.php
@@ -12,9 +12,9 @@ public function testBaiscs(): void
         $stdClass = new \stdClass();
 
         $counter = new Counter($stdClass);
-        self::assertSame(0, $counter->count());
+        self::assertCount(0, $counter);
 
         $counter = new Counter($stdClass, 5);
-        self::assertSame(5, $counter->count());
+        self::assertCount(5, $counter);
     }
 }
diff --git a/tests/cases/SportRangeTest.php b/tests/cases/SportRangeTest.php
@@ -22,19 +22,19 @@ public function testBaiscs(): void
     public function testIsWithin(): void
     {
         $range = new SportRange(3, 5);
-        self::assertSame(false, $range->isWithIn(2));
-        self::assertSame(true, $range->isWithIn(3));
-        self::assertSame(true, $range->isWithIn(4));
-        self::assertSame(true, $range->isWithIn(5));
-        self::assertSame(false, $range->isWithIn(6));
+        self::assertFalse($range->isWithIn(2));
+        self::assertTrue($range->isWithIn(3));
+        self::assertTrue($range->isWithIn(4));
+        self::assertTrue($range->isWithIn(5));
+        self::assertFalse($range->isWithIn(6));
     }
 
     public function testEquals(): void
     {
         $range = new SportRange(3, 5);
-        self::assertSame(false, $range->equals(new SportRange(2, 5)));
-        self::assertSame(false, $range->equals(new SportRange(3, 4)));
-        self::assertSame(true, $range->equals(new SportRange(3, 5)));
+        self::assertFalse($range->equals(new SportRange(2, 5)));
+        self::assertFalse($range->equals(new SportRange(3, 4)));
+        self::assertTrue($range->equals(new SportRange(3, 5)));
     }
 
     public function testToArray(): void