Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-picked] Fix SPI clean up incase of errors for insert into execute with @tablevarible #18

Open
wants to merge 17 commits into
base: BABEL_3_X_DEV
Choose a base branch
from

Conversation

thephantomthief
Copy link
Owner

Description

[Describe what this change achieves - Guidelines below (please delete the guidelines after writing the PR description)]

  1. What is the change? This is best described in terms of “Currently, Babelfish does X. With this change it now does Y.” Think of “What did it used to do?” and “What does it do now?”
  1. Why was the change made? What drove our desire to put effort into the change?
  2. How was the code changed should only appear for large commits. This can serve as a rough roadmap to what’s contained in the commit. It should be very high level; if it’s directly referencing code it’s probably too detailed. It’s also critical that this section of a commit message does not try to replace proper code documentation (ie, block comments or README files). Generally, this section should only appear if the commit itself is large enough that it’s helpful to provide a roadmap to someone looking at the commit.
  3. The last descriptive piece is the “title” for the commit: the very first line of the commit message, which should typically be less than 80 characters. A good title is critical, because it’s the only thing that shows up in places like the Github commit listing. No one’s got time to read through full commit messages when trying to find a single commit out of dozens.

Issues Resolved

[List any issues this PR will resolve]

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

thephantomthief and others added 17 commits December 26, 2023 15:28
* add code coverage for pull requests

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* refactoring

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* refactoring

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* change event condititon to pull_request from worflow_call

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* fix name for downloading artifact

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* temp changes to check failure scenario

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* remove temp changes

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* refactor names for artifacts to be uploaded

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* empty commit to rerun actions

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* fix name for download artifact

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* empty commit to rerun actions

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* build postgres with code coverage only if flag is set

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* empty commit to rerun actions

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

* integrate with coveralls

* add src line

---------

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Co-authored-by: Tanzeel Khan <tzlkhan@amazon.com>
Co-authored-by: Tanzeel Khan <140405735+tanscorpio7@users.noreply.github.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Copy link

github-actions bot commented Dec 28, 2023

Pull Request Test Coverage Report for Build 7344866682

  • 22 of 24 (91.67%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 72.197%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contrib/babelfishpg_tsql/src/pl_handler.c 20 22 90.91%
Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tsql/src/pl_handler.c 1 90.9%
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 2 74.37%
Totals Coverage Status
Change from base Build 7344819462: 0.0%
Covered Lines: 39382
Relevant Lines: 54548

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants