Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defun! variant of defmacro! #13

Merged
merged 8 commits into from Aug 24, 2015
Merged

Add defun! variant of defmacro! #13

merged 8 commits into from Aug 24, 2015

Conversation

EuAndreh
Copy link
Contributor

@EuAndreh EuAndreh commented Aug 3, 2015

You think that's worth adding?

@EuAndreh
Copy link
Contributor Author

EuAndreh commented Aug 3, 2015

Now one can write:

(defmacro! my-macro (a b)
  (declare (ignore a)) 
    ...)

... and get the expected behaviour, with or without docstrings.

@PuercoPop
Copy link

May I suggest alexandria:parse-body a less concrete way to extract declarations and docstrings?

@EuAndreh
Copy link
Contributor Author

EuAndreh commented Aug 3, 2015

Nice tip @PuercoPop =]

@thephoeron
Copy link
Owner

@EuAndreh: Before we merge in this pull request, can you add some tests for the new forms?

@EuAndreh
Copy link
Contributor Author

Sure. I'll do it tonight, as soon as I get home.

@EuAndreh
Copy link
Contributor Author

Is that what you had in mind? Do you suggest adding some more things?

@EuAndreh
Copy link
Contributor Author

Now one can test with (asdf:test-system :let-over-lambda).

thephoeron added a commit that referenced this pull request Aug 24, 2015
Add defun! variant of defmacro!
@thephoeron thephoeron merged commit c406ce5 into thephoeron:master Aug 24, 2015
@thephoeron
Copy link
Owner

Nice! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants