Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected League\CLImate\string, got string for PHP 5.6 #137

Closed
wants to merge 2 commits into from
Closed

Expected League\CLImate\string, got string for PHP 5.6 #137

wants to merge 2 commits into from

Conversation

rvalitov
Copy link

I had to close the previous pull request #134 and reopen it here.

I use the latest PhpStorm 2018.2.5 and when I use Code Inspection, I see the following warning message for most methods (e.g. inline, out, etc.):

Expected League\CLImate\string, got string. 
Invocation parameter types are not compatible with declared.

Screenshot:

image

This problem happens when I set PhpStorm in PHP 5.6 compatibility mode, because we can not use scalar type hint in PHP < 7.0, therefore should remove the string in declarations. According to the composer file your project is PHP 5.6 compatible, therefore such modification is eligible.

I searched the Internet for similar problems. It happened for other projects, too, for example in Yii2. And it was solved by a similar commit.

@duncan3dc
Copy link
Member

Hi @rvalitov, thanks for your contribution but unfortunately as support for PHP 5.6 has ended we will not be releasing any more versions of CLImate for it. The next version will require a currently supported version of PHP (7.1+)

@duncan3dc duncan3dc closed this Feb 10, 2019
@rvalitov
Copy link
Author

@duncan3dc Thank you for dropping the 5.6 support from the composer.json. Without that it was very confusing and that's why I had to make this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants