Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of stuff for Travis CI #58

Merged
merged 2 commits into from
Jul 29, 2015
Merged

A bunch of stuff for Travis CI #58

merged 2 commits into from
Jul 29, 2015

Conversation

duncan3dc
Copy link
Member

  • Use composer update to test against the highest dependencies
  • Also test against the lowest supported dependencies
  • Use travis_retry for the composer commands (in case they fail due to an intermittent connectivity issue)

@duncan3dc
Copy link
Member Author

Doing this uncovered an issue in the dependencies (on hhvm) but I don't have a hhvm setup to work through this right now

@joetannenbaum
Copy link
Contributor

This feels like it might be overkill as CLImate has virtually no dependencies (just dev dependencies), right?

@duncan3dc
Copy link
Member Author

Yeh that's a good point. I would probably do it anyway just so it's covered for any dependencies added in the future. But I can drop that and just leave the update command and the retry parts if you prefer?

joetannenbaum added a commit that referenced this pull request Jul 29, 2015
@joetannenbaum joetannenbaum merged commit 2b2fa2e into thephpleague:master Jul 29, 2015
@duncan3dc duncan3dc deleted the travis-improvements branch September 9, 2015 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants